Hi I’m Phil 👋, I’m a software engineer, and I maintain an open source push notification tool called ntfy. I’m also German 🇩🇪, and a big fan of 🇬🇧 & 🇺🇸, and a dad of two 👦👧

  • 6 Posts
  • 36 Comments
Joined 1 year ago
cake
Cake day: June 11th, 2023

help-circle















  • binwiederhier@discuss.ntfy.shtoLemmy@lemmy.mlLemmy v0.18.0 Release
    link
    fedilink
    English
    arrow-up
    16
    ·
    edit-2
    1 year ago

    WebSockets … causing live updates to the site which many users dislike

    I appreciate all the work in this release. It’s insane how much you packed into one release. Well done. I am most excited about the live updates going away. It was quite disruptive. Thanks for that.

    That said, WebSockets can be implemented very efficiently. I run an open source notification service called ntfy, and the public instance ntfy.sh currently keeps 6-8k WebSocket connections and thousands more HTTP stream (long polling HTTP) open, all on a 2 core machine with 4GB of RAM. My point being that WebSockets can be implemented very efficiently. Though in Lemmy’s case it’s likely not necessary.

    – Another thing I wanted to notice is that I am missing mentions of security issues in the release notes. There are some tickets that sound really really really bad, like this one: https://github.com/LemmyNet/lemmy/issues/3060

    Isn’t that more important than anything else?


  • You got a lot of heat in this discussion, but let me be one of the few to applaud you for actually making a proposal. Saying No is easy, but suggesting something and writing it down and putting it out there is hard.

    I am a Principal Engineer by trade, and i do what you did here all the time. I put out suggestions to my team and let them absolutely wreck it. This is how you advance and enhance your idea. Listen and learn from the feedback and suggest another thing based on what you have learned. Rinse and repeat.

    That’s how you get to a great proposal. Keep at it. Well done.